From 66f4a056b75027eeec7518d45a35f56932452c5a Mon Sep 17 00:00:00 2001
From: Mo8it <mo8it@proton.me>
Date: Sun, 18 Apr 2021 17:24:40 +0200
Subject: [PATCH] Added registering as admin and assistant, added inactive
 users table.

---
 advlabdb/forms.py                  |  5 ++--
 advlabdb/routes.py                 | 40 ++++++++++++++++++++----------
 advlabdb/templates/register.html   |  6 +++++
 advlabdb/templates/registered.html |  8 +-----
 advlabdb/templates/users.html      |  8 ++++--
 advlabdb/utils.py                  |  2 +-
 6 files changed, 44 insertions(+), 25 deletions(-)

diff --git a/advlabdb/forms.py b/advlabdb/forms.py
index 1f2d09d..e162180 100644
--- a/advlabdb/forms.py
+++ b/advlabdb/forms.py
@@ -7,11 +7,12 @@ from advlabdb.models import User
 class RegistrationForm(FlaskForm):
     email = StringField("Email",
                         validators=[DataRequired(), Email()])
+    assistant = BooleanField("Assistant", default=True)
     admin = BooleanField("Admin", default=False)
     submit = SubmitField("Register")
 
-    def validate_email(self, email):
-        user = User.query.filter_by(email=email.data.lower()).first()
+    def validate_email(form, field):
+        user = User.query.filter_by(email=field.data.lower()).first()
         if user:
             raise ValidationError("A user with this email address is already registered!")
 
diff --git a/advlabdb/routes.py b/advlabdb/routes.py
index 8efddfa..adc3ff4 100644
--- a/advlabdb/routes.py
+++ b/advlabdb/routes.py
@@ -188,12 +188,16 @@ def users():
                              ["Roles", "[role.name for role in row.roles]"],
                              ["Assistant", "row.assistant"]]
 
-        table = makeTable(headerAndDataList=headerAndDataList,
-                          rows=User.query.filter(User.active == True).all(),
-                          tableId="usersTab")
+        activeUsersTable = makeTable(headerAndDataList=headerAndDataList,
+                                     rows=User.query.filter(User.active == True).all(),
+                                     tableId="activeUsersTable")
+        inactiveUsersTable = makeTable(headerAndDataList=headerAndDataList,
+                                       rows=User.query.filter(User.active == False).all(),
+                                       tableId="inactiveUsersTable")
 
         return render_template("users.html",
-                               table=table,
+                               activeUsersTable=activeUsersTable,
+                               inactiveUsersTable=inactiveUsersTable,
                                )
 
 
@@ -248,21 +252,31 @@ def register():
         passwordHash = hash_password(password)
 
         email = form.email.data.lower()
+        assistant = form.assistant.data
         admin = form.admin.data
 
+        registered = True
         if admin:
-            roles = ["admin"]
+            if assistant:
+                roles = ["admin", "assistant"]
+            else:
+                roles = ["admin"]
             flash("You have registered a new admin!", "danger")
-        else:
+        elif assistant:
             roles = ["assistant"]
+        else:
+            flash("The user has to be assistant and/or admin!", "warning")
+            registered = False
+
+        if registered:
+            newUser = user_datastore.create_user(email=email, password=passwordHash, roles=roles)
+            db.session.commit()
+            return render_template("registered.html",
+                                   email=email,
+                                   password=password,
+                                   roles=[role.name for role in newUser.roles],
+                                   )
 
-        user_datastore.create_user(email=email, password=passwordHash, roles=roles)
-        db.session.commit()
-        return render_template("registered.html",
-                               email=email,
-                               password=password,
-                               admin=admin,
-                               )
     return render_template("register.html",
                            form=form,
                            )
diff --git a/advlabdb/templates/register.html b/advlabdb/templates/register.html
index 5a1549d..3961499 100644
--- a/advlabdb/templates/register.html
+++ b/advlabdb/templates/register.html
@@ -3,6 +3,7 @@
 {% block content %}
 <div class="content-section">
   <form method="POST">
+    {{form.hidden_tag()}}
     <fieldset>
       <div>
         {{form.email.label(class="form-control-label")}}
@@ -18,7 +19,12 @@
             {{form.email(class="form-control form-control-lg")}}
         {% endif %}
       </div>
+      <br>
+      Roles
       <div class="form-check">
+        {{form.assistant(class="form-check-input")}}
+        {{form.assistant.label(class="form-check-label")}}
+        <br>
         {{form.admin(class="form-check-input")}}
         {{form.admin.label(class="form-check-label")}}
       </div>
diff --git a/advlabdb/templates/registered.html b/advlabdb/templates/registered.html
index 1b3b480..8bd8875 100644
--- a/advlabdb/templates/registered.html
+++ b/advlabdb/templates/registered.html
@@ -2,13 +2,7 @@
 {% extends "layout.html" %}
 {% block content %}
 <h3>
-  Registered as
-  {% if admin %}
-  <strong>Admin</strong>
-  {% else %}
-  Assistant
-  {% endif %}
-  !
+  New user registered with roles {{roles}}.
 </h3>
 <p>
   Email: {{email}}
diff --git a/advlabdb/templates/users.html b/advlabdb/templates/users.html
index ff50bd1..f61c5ef 100644
--- a/advlabdb/templates/users.html
+++ b/advlabdb/templates/users.html
@@ -2,7 +2,8 @@
 {% extends "layout.html" %}
 {% block content %}
 
-{{table|safe}}
+<h3>Active users:</h3>
+{{activeUsersTable|safe}}
 <div>
   <button id="deactivateUsersButton" class="btn btn-warning">Deactivate users</button>
 </div>
@@ -11,11 +12,14 @@
   <button type="submit" name="registerUser" class="btn btn-primary">Register a new user</button>
 </form>
 
+<hr>
+<h3>Inactive users:</h3>
+{{inactiveUsersTable|safe}}
 {% endblock content %}
 
 {% block scripts %}
 <script>
-  let $table = $('#usersTab')
+  let $table = $('#activeUsersTable')
   let $button = $('#deactivateUsersButton')
 
   $(function() {
diff --git a/advlabdb/utils.py b/advlabdb/utils.py
index 2168abf..1410624 100644
--- a/advlabdb/utils.py
+++ b/advlabdb/utils.py
@@ -1,7 +1,7 @@
 from random import choice
 from string import digits, ascii_letters
 
-def makeTable(headerAndDataList, rows, tableId="tab"):
+def makeTable(headerAndDataList, rows, tableId="table"):
     def cellString(cell):
         cell = str(cell)
         if cell == "[]":